Fix NoMethodError

penguoir · Feb 15, 2024 · 80a0770 · 80a0770
1 parent 52fd730
commit 80a0770
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/active_cortex/generator/boolean.rb b/lib/active_cortex/generator/boolean.rb
@@ -28,7 +28,7 @@ def openai_error_message
   end
 
   def convert_to_boolean(content)
-    content = content.downcase.gsub(/[^a-z]/, "")
+    content = content&.downcase&.gsub(/[^a-z]/, "")
 
     case content
     when "yes", "true", "1"

diff --git a/spec/active_cortex/generator/boolean_spec.rb b/spec/active_cortex/generator/boolean_spec.rb
@@ -18,6 +18,13 @@
     end
   end
 
+  context "when OpenAI returns an error" do
+    it "raises an error" do
+      stub_request(:post, "https://api.openai.com/v1/chat/completions").to_return(status: 500)
+      expect { generator.generation }.to raise_error(ActiveCortex::Error)
+    end
+  end
+
   context "when saving the generation" do
     it "saves the generation to the record", :vcr do
       generator.save_generation