Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funding: create epoch LQT nullifier set #5029

Closed
Tracked by #5010
erwanor opened this issue Jan 30, 2025 · 0 comments
Closed
Tracked by #5010

funding: create epoch LQT nullifier set #5029

erwanor opened this issue Jan 30, 2025 · 0 comments
Assignees

Comments

@erwanor
Copy link
Member

erwanor commented Jan 30, 2025

We define a new state key module in the funding component: state_key::lqt::v1::nf::by_epoch which maps a nullifier to a TransactionId.

funding/lqt/v1/nf/by_epoch/{index:020}/lookup/{nullifier}

We want to have a simple extension trait that lets us read/check/prefix scan over the grilled nullifiers for the epoch.

We want the nullifier key to map to a TransactionId (hash). This means we will have to extend the TransactionContext to make it available when the action gets executed.

@erwanor erwanor mentioned this issue Jan 30, 2025
28 tasks
@erwanor erwanor assigned TalDerei and cronokirby and unassigned TalDerei Jan 30, 2025
@TalDerei TalDerei assigned TalDerei and unassigned cronokirby Jan 30, 2025
cronokirby pushed a commit that referenced this issue Jan 31, 2025
## Describe your changes

state key for epoch-scoped nullifier set (mapping nullifiers with their
associated transaction id), serving as a precursor for performing the
necessary stateful [nullifier
check](https://github.com/penumbra-zone/penumbra/pull/5033/files#diff-a0986b8d223ab5b1c5536ba06bde1ede6d08f635eb97b386549ecfb55a4f2a4bR112).
Additionally, augments the transaction context with `TransactionId`.

## Issue ticket number and link

references #5029

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > LQT branch
conorsch pushed a commit that referenced this issue Jan 31, 2025
## Describe your changes

state key for epoch-scoped nullifier set (mapping nullifiers with their
associated transaction id), serving as a precursor for performing the
necessary stateful [nullifier
check](https://github.com/penumbra-zone/penumbra/pull/5033/files#diff-a0986b8d223ab5b1c5536ba06bde1ede6d08f635eb97b386549ecfb55a4f2a4bR112).
Additionally, augments the transaction context with `TransactionId`.

## Issue ticket number and link

references #5029

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > LQT branch
conorsch pushed a commit that referenced this issue Feb 4, 2025
## Describe your changes

state key for epoch-scoped nullifier set (mapping nullifiers with their
associated transaction id), serving as a precursor for performing the
necessary stateful [nullifier
check](https://github.com/penumbra-zone/penumbra/pull/5033/files#diff-a0986b8d223ab5b1c5536ba06bde1ede6d08f635eb97b386549ecfb55a4f2a4bR112).
Additionally, augments the transaction context with `TransactionId`.

## Issue ticket number and link

references #5029

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > LQT branch
conorsch pushed a commit that referenced this issue Feb 5, 2025
## Describe your changes

state key for epoch-scoped nullifier set (mapping nullifiers with their
associated transaction id), serving as a precursor for performing the
necessary stateful [nullifier
check](https://github.com/penumbra-zone/penumbra/pull/5033/files#diff-a0986b8d223ab5b1c5536ba06bde1ede6d08f635eb97b386549ecfb55a4f2a4bR112).
Additionally, augments the transaction context with `TransactionId`.

## Issue ticket number and link

references #5029

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > LQT branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants