distributions: add distributions events #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalDerei
added
the
consensus-breaking
TalDerei
changed the title
TalDerei
commented
Feb 2, 2025
|
I think we should go ahead and add an event type for this, since we'll be writing an app view for the events here at some point. For emission, c.f. as an example |
erwanor
reviewed
Feb 3, 2025
| .get_cummulative_lqt_reward_issuance(current_epoch.index - 1) | ||
| .await | ||
| .ok_or_else(|| { | ||
| tonic::Status::not_found(format!( |
There was a problem hiding this comment.
This is not an RPC, so we shouldn't return an RPC error. In fact, we shouldn't return an error at all. We do not want to interrupt component logic. Just default to zero.
erwanor
reviewed
Feb 3, 2025
| )); | ||
|
|
||
| self.set_lqt_reward_issuance_for_epoch(current_epoch.index, new_issuance); | ||
| self.set_cumulative_lqt_reward_issuance(current_epoch.index, cumulative_issuance); |
There was a problem hiding this comment.
This method only gets called at the end of every epoch, so something is wrong here right?
There was a problem hiding this comment.
well in the way I interpreted the event definition and it's associated fields (event emission every epoch), the logic is correct. I'll modify it to instead emit an event every block 👍
erwanor
reviewed
Feb 3, 2025
| let cumulative_issuance = previous_issuance + new_issuance; | ||
|
|
||
| // Emit an event for LQT pool size increase. | ||
| self.record_proto(event::event_lqt_pool_size_increase( |
There was a problem hiding this comment.
We should emit an event every block, but we don't need to do anything else, the goal for this event is to be a convenient tick for observability, that's all we need imo.
erwanor
requested changes
Feb 3, 2025
conorsch
pushed a commit
that referenced
this pull request
Feb 4, 2025
## Describe your changes add LQT pool size increase event to the distributions component, emitted at the end of each block. ## Issue ticket number and link references #5041 ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > LQT branch
conorsch
pushed a commit
that referenced
this pull request
Feb 5, 2025
## Describe your changes add LQT pool size increase event to the distributions component, emitted at the end of each block. ## Issue ticket number and link references #5041 ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > LQT branch
conorsch
pushed a commit
that referenced
this pull request
Feb 5, 2025
## Describe your changes add LQT pool size increase event to the distributions component, emitted at the end of each block. ## Issue ticket number and link references #5041 ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > LQT branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
add LQT pool size increase event to the distributions component, emitted at the end of each block.
Issue ticket number and link
references #5041
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: