forked from rbarrois/django_xworkflows
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream #4
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drop Python2 - Only test Django 1.11 on Python3 - Only test the latest Django version (3.0) and the previous LTS (2.2)
- Remove python2_unicode_compatible - Drop unicode/str conversions
- Replace ugettext_lazy with gettext_lazy, since the `unicode` class no longer exists; - Rename `MIDDLEWARE_CLASSES` to `MIDDLEWARE`
Use `./manage.py test` instead of a custom runner setup.
Include migrations for the `djworkflows` project.
Semantically closer to the actual goal.
Only keep the "Build with Makefile" part in setup.py, as that part is required for properly compiling the .po/.mo files. Requirements are now described in extras, relying only on the standard supported tools.
A package's `sdist` archive should contain all files required for building said projects, including tests, docs, etc.
Use a standardized package layout, with centralized tool configuration.
Also add a `docs` check environment. Note: explicit installation of `gettext` is now required.
Not supported on Github Actions.
Django 3.x requires Python >= 3.6
Due to CI limitations, it is no longer possible to test the code with Python 3.4.
With Django 3.2, projects must specify whether the implicit autofield used for models is an integer or a big integer. Since that doesn't actually matter in our test setup, simply use the recommended BigAutoField. Note that this change has no effect on the default "Workflow transition log" models.
XWorkflows recommends not using `@transition(..., after=)` for quite many releases; replace this pattern with the supported `@after_transition` pattern.
In order to quickly detect pending deprecation warnings in our supporting libraries, mark warnings as errors in our automated testing setups.
There is a small typo in docs/index.rst. Should read `functionalities` rather than `functionnalities`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop all peopledoc commits