Skip to content

Commit

Permalink
feat: add deprecation warning (#174)
Browse files Browse the repository at this point in the history
  • Loading branch information
GreatWizard authored Dec 2, 2021
1 parent 0d740b0 commit bbc19d8
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 5 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
[![CI](https://github.com/peopledoc/ember-metrics-pendo/actions/workflows/ci.yml/badge.svg)](https://github.com/peopledoc/ember-metrics-pendo/actions/workflows/ci.yml) [![Ember Observer Score](https://emberobserver.com/badges/ember-metrics-pendo.svg)](https://emberobserver.com/addons/ember-metrics-pendo)
[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)

## Deprecation Warning ⚠️

> This add-on has been merged into [`ember-metrics`](https://github.com/adopted-ember-addons/ember-metrics).
>
> Please use `ember-metrics` v1.4.0+ instead and remove `ember-metrics-pendo` from your dependencies.
## About this addon

Ember-metrics-pendo allows to configure the [Pendo](https://www.pendo.io) service in your ember project using [ember-metrics](https://github.com/poteto/ember-metrics).
Expand Down
11 changes: 9 additions & 2 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ module.exports = async function () {
},
{
name: 'ember-release',
allowedToFail: true,
npm: {
devDependencies: {
'ember-source': await getChannelURL('release'),
Expand All @@ -33,6 +34,7 @@ module.exports = async function () {
},
{
name: 'ember-beta',
allowedToFail: true,
npm: {
devDependencies: {
'ember-source': await getChannelURL('beta'),
Expand All @@ -41,6 +43,7 @@ module.exports = async function () {
},
{
name: 'ember-canary',
allowedToFail: true,
npm: {
devDependencies: {
'ember-source': await getChannelURL('canary'),
Expand Down Expand Up @@ -78,8 +81,12 @@ module.exports = async function () {
},
},
},
embroiderSafe(),
embroiderOptimized(),
embroiderSafe({
allowedToFail: true,
}),
embroiderOptimized({
allowedToFail: true,
}),
],
}
}
9 changes: 9 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,13 @@

module.exports = {
name: require('./package').name,

included(parent) {
this._super.included.apply(this, arguments)
console.warn(
`⚠️ DEPRECATION: [ember-metrics-pendo] Please use ember-metrics v1.4.0+ which includes the adapter for Pendo and remove ember-metrics-pendo from your dependencies.
See https://github.com/adopted-ember-addons/ember-metrics for more details.`
)
return parent
},
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ember-metrics-pendo",
"version": "1.3.1",
"version": "1.3.2",
"description": "An ember-metrics integration for Pendo.",
"keywords": [
"ember-addon"
Expand Down Expand Up @@ -29,7 +29,7 @@
"ember-classic-decorator": "^2.0.0",
"ember-cli-babel": "^7.26.6",
"ember-cli-htmlbars": "^6.0.0",
"ember-metrics": "^1.3.1"
"ember-metrics": "~1.3.1"
},
"devDependencies": {
"@ember/optional-features": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4973,7 +4973,7 @@ ember-maybe-import-regenerator@^1.0.0:
ember-cli-babel "^7.26.6"
regenerator-runtime "^0.13.2"

ember-metrics@^1.3.1:
ember-metrics@~1.3.1:
version "1.3.1"
resolved "https://registry.yarnpkg.com/ember-metrics/-/ember-metrics-1.3.1.tgz#2b90dd6e8356ee124ce35dbd4bac29cc22b49898"
integrity sha512-0feFXLXvgodjjBb02SvQT2isCifcXmJTIizqwRDgl6kgEUWPYreUBLvNUHm8pgddRGI1e/o5115dx5lYeoH9Vg==
Expand Down

0 comments on commit bbc19d8

Please sign in to comment.