Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atmosphere doesn't show anything special for unmigrated packages #308

Closed
dandv opened this issue Nov 30, 2014 · 3 comments
Closed

Atmosphere doesn't show anything special for unmigrated packages #308

dandv opened this issue Nov 30, 2014 · 3 comments
Labels
confirmed enhancement fixed
Milestone
Current Release

Comments

@dandv
Copy link

dandv commented Nov 30, 2014 

$ meteor admin set-unmigrated summernote:summernote-compat
Setting summernote:[email protected] as unsuccessfully migrated ... done!
Setting summernote:[email protected]_1 as unsuccessfully migrated ... done!

...wait 20 minutes...

https://atmospherejs.com/summernote/summernote-compat shows as any regular package.

Since set-unmigrated is currently our only mechanism of indicating that a package should not be used, I believe Atmosphere should reflect that in the package page in a more prominent manner than just displaying an empty History section.
@dandv dandv mentioned this issue Nov 30, 2014
Open
@tmeasday
Copy link
Member

tmeasday commented Dec 1, 2014

You're right, it should show something. OTOH they don't come up in search results, so that's good.

@tmeasday tmeasday added this to the Next Up milestone Dec 1, 2014
@tmeasday tmeasday assigned dburles and unassigned domyen and dburles Dec 1, 2014
@dburles dburles assigned domyen and unassigned dburles Dec 4, 2014
@dburles
Copy link

dburles commented Dec 4, 2014

@dominicnguyen I've added a placeholder on the packages page, up to you on how best to display it

@domyen
Copy link
Member

domyen commented Dec 10, 2014

Thanks dave. Packages now get auto-flagged if they're unmigrated.

@domyen domyen removed their assignment Dec 10, 2014
@domyen domyen added the fixed label Dec 10, 2014
@dburles dburles removed their assignment Dec 10, 2014
@tmeasday tmeasday modified the milestones: Next Up, Current Release Dec 19, 2014
@dandv dandv mentioned this issue Dec 19, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed enhancement fixed
Projects
None yet
Milestone
Current Release
Development

No branches or pull requests
4 participants
@dandv @tmeasday @domyen @dburles