-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct integration, similar to d3, with tests #14
Comments
I'm happy to do this and reduce the maintaining load. However, I recently took this over from @yasinuslu and I'm definitely not as familiar with hooking into other packages' build process like you - so you should feel free to take a stab if you're in the mood. I think this entire process would be much better served with having package renaming, including author/organization - that would streamline the migration a lot better and maintain continuity for existing installs. @ekatek, any updates on when that will be possible? |
In the meantime I've hooked into Bootstrap's Gruntfile so the maintenance load could be effectively zero. We're live at http://atmospherejs.com/twbs/bootstrap Waiting for any final feedback/thoughts before submitting the PR. |
Thanks for your work on this. I've been busy with some other stuff lately but will hopefully have a chance to pitch in over the holidays. |
Hey @dandv, is it safe to set this package as unmigrated now and recommend that people switch to |
Yes, I do believe so. I've battle-tested it from apps and other packages, e.g. @FezVrasta's Material Design Theme, and it's been through several rounds of feedback from the Bootstrap folks. |
OK, unmigrated and README updated. Good luck to |
🙇 & 👍 https://atmospherejs.com/?q=bootstrap still shows it though? Maybe related to percolatestudio/atmosphere#320 ? |
I don't know if atmosphere looks for unmigrated. I'd be surprised if it does. |
Looks good now, no? |
Since you've been shepherding this for quite a while, might you take a look at my stab at a direct integration?
https://github.com/dandv/bootstrap/compare/meteor-integration
Tests run mostly ok, though I'm not sure why only some JS works (see the README).
Would be great if we could get the Bootstrap folks to pull in a solid PR.
The text was updated successfully, but these errors were encountered: