Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct integration, similar to d3, with tests #14

Closed
dandv opened this issue Nov 28, 2014 · 11 comments
Closed

Direct integration, similar to d3, with tests #14

dandv opened this issue Nov 28, 2014 · 11 comments

Comments

@dandv
Copy link

dandv commented Nov 28, 2014

Since you've been shepherding this for quite a while, might you take a look at my stab at a direct integration?

https://github.com/dandv/bootstrap/compare/meteor-integration

Tests run mostly ok, though I'm not sure why only some JS works (see the README).

Would be great if we could get the Bootstrap folks to pull in a solid PR.

@mizzao
Copy link
Owner

mizzao commented Nov 29, 2014

I'm happy to do this and reduce the maintaining load. However, I recently took this over from @yasinuslu and I'm definitely not as familiar with hooking into other packages' build process like you - so you should feel free to take a stab if you're in the mood.

I think this entire process would be much better served with having package renaming, including author/organization - that would streamline the migration a lot better and maintain continuity for existing installs. @ekatek, any updates on when that will be possible?

@dandv
Copy link
Author

dandv commented Nov 29, 2014

In the meantime I've hooked into Bootstrap's Gruntfile so the maintenance load could be effectively zero.

We're live at http://atmospherejs.com/twbs/bootstrap

Waiting for any final feedback/thoughts before submitting the PR.

@dandv
Copy link
Author

dandv commented Dec 16, 2014

@mizzao
Copy link
Owner

mizzao commented Dec 18, 2014

Thanks for your work on this. I've been busy with some other stuff lately but will hopefully have a chance to pitch in over the holidays.

@mizzao
Copy link
Owner

mizzao commented Dec 19, 2014

Hey @dandv, is it safe to set this package as unmigrated now and recommend that people switch to twbs:bootstrap instead?

@dandv
Copy link
Author

dandv commented Dec 19, 2014

Yes, I do believe so. I've battle-tested it from apps and other packages, e.g. @FezVrasta's Material Design Theme, and it's been through several rounds of feedback from the Bootstrap folks.

@mizzao mizzao closed this as completed in 40d6170 Dec 19, 2014
@mizzao
Copy link
Owner

mizzao commented Dec 19, 2014

OK, unmigrated and README updated. Good luck to twbs:bootstrap, you should see a ton of users switch over soon.

@dandv
Copy link
Author

dandv commented Dec 19, 2014

🙇 & 👍

https://atmospherejs.com/?q=bootstrap still shows it though?

Maybe related to percolatestudio/atmosphere#320 ?

@mizzao
Copy link
Owner

mizzao commented Dec 19, 2014

I don't know if atmosphere looks for unmigrated. I'd be surprised if it does.

@dandv
Copy link
Author

dandv commented Dec 19, 2014

@tmeasday
Copy link

Looks good now, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants