PS-4711: crash on TokuDB PFS-instrumented mutexes deinitialization #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shutdown_performance_schema() is always invoked before exit(), what means global mutexes are always destroyed after perfomance schema shutdown, what causes SIGFAULT on some platforms(debian wheeze in particular). For PerconaFT layer the fix is in invoking ydb-layer deinitialization function explicitly from storage engine shutdown function. But the same function is also invoked on library unload, see libtokuft_destroy(). The certain flag is used to avoid invoking ydb-layer deinitialization function twice.
george-lorch
approved these changes
Aug 9, 2018
laurynas-biveinis
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shutdown_performance_schema() is always invoked before exit(), what means
global mutexes are always destroyed after perfomance schema shutdown, what
causes SIGFAULT on some platforms(debian wheeze in particular).
For PerconaFT layer the fix is in invoking ydb-layer deinitialization function
explicitly from storage engine shutdown function. But the same function is also
invoked on library unload, see libtokuft_destroy(). The certain flag is used to
avoid invoking ydb-layer deinitialization function twice.
Testing:
https://jenkins.percona.com/view/5.7/job/mysql-5.7-param/1891/
See also: percona/percona-server#2479