EVEREST-1799 Configure OIDC scope #1063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabio-silva
approved these changes
Jan 28, 2025
oksana-grishchenko
approved these changes
Jan 28, 2025
maxkondr
requested changes
Jan 28, 2025
fabio-silva
approved these changes
Jan 28, 2025
oksana-grishchenko
approved these changes
Jan 29, 2025
maxkondr
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #980 we added the ability to fetch user groups from the external IdP. However, we can't always request the groups scope during the OIDC flow. This is because the IdP might not support it, or the user might not have configured it.
In order to keep backwards compatibility, we need to add a new field to the settings API that returns the user configured OIDC scope. Like the other OIDC settings this can only be configured through the CLI. By default, the scope should be
openid profile email.Related PRs: