Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1267 Remove unused function: NewRestoreJob(cr *api.PerconaServerMongoDBRestore) Job #1812

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

gkech
Copy link
Contributor

@gkech gkech commented Jan 27, 2025

https://perconadev.atlassian.net/browse/K8SPSMDB-1267

CHANGE DESCRIPTION

Problem:

Noticed that the function

NewRestoreJob(cr *api.PerconaServerMongoDBRestore) Job

Is not used throughout the codebase, so we can remove it.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Jan 27, 2025
@gkech gkech changed the title Remove unused function Remove unused function: NewRestoreJob(cr *api.PerconaServerMongoDBRestore) Job Jan 27, 2025
@gkech gkech marked this pull request as ready for review January 27, 2025 16:49
@gkech gkech changed the title Remove unused function: NewRestoreJob(cr *api.PerconaServerMongoDBRestore) Job K8SPSMDB-1267 Remove unused function: NewRestoreJob(cr *api.PerconaServerMongoDBRestore) Job Jan 27, 2025
@hors hors merged commit 9d11a46 into main Jan 28, 2025
16 of 17 checks passed
@hors hors deleted the remove-not-used-function branch January 28, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants