Fix PS-4723 (PURGE CHANGED_PAGE_BITMAPS doesn't work when innodb_data_home_dir used) (5.7) #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build link |
…ta_home_dir used) https://jira.percona.com/browse/PS-4723 'PURGE CHANGED_PAGE_BITMAPS' InnoDB handler ('log_online_purge_changed_page_bitmaps()') used to call 'os_file_delete_if_exists()' for deleting old '.xdb' files using relative paths. Therefore, when '--innodb-data-home-dir' was different from '--datadir'(which is by default the current working directory), it tried to delete these file from the wrong location. Fixed by prepending '.xdb' file name with 'log_bmp_sys->bmp_file_home' in the case when redo log tracking is enabled or with 'srv_data_home' otherwise. 'innodb.percona_changed_page_bmp_requests_debug' MTR test case extendes with a new section which simulates the reported scenario.
…6-bugps4723-purge_changed_page_bitmaps
…7-bugps4723-purge_changed_page_bitmaps
percona-ysorokin
force-pushed
the
ps-5.7-bugps4723-purge_changed_page_bitmaps
branch
from
88395a9 to
89b68e6
Compare
|
Removed --innodb-file-per-table=0 option along with assertion from the second (non-tracking) restart. |
laurynas-biveinis
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.