Fixed PS-1107 (LP #1703346: Binlog corruption when tmpdir gets full) (5.7) #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not following GCA here as proper 'out of disk space' simulation requires 'simulate_disk_full_at_flush_pending' DBUG directive from Bug #27399620: BINLOG AND ENGINE BECOME INCONSISTENT WHEN BINLOG CACHE FILE GETS OUT OF SPACE Jenkins build link |
laurynas-biveinis
suggested changes
Sep 26, 2018
…(5.7) https://jira.percona.com/browse/PS-1107 Cherry-picked from ps-5.6-bugps1107-tmpdir_full branch (commit 96bbeec). Fixed problem with wrapping 'reinit_io_cache()' inside 'MYSQL_BIN_LOG::do_write_cache()' with 'simulate_file_write_error' DBUG directive. 'DBUG_SET("-d,simulate_file_write_error")' should be called not only when 'reinit_io_cache()' fails but when it succeeds as welll. Whithout this patch, any subsequent call to 'my_write()' ends up with an infinite loop. Reorganized 'rpl.rpl_bug72457' MTR test case. Instead, we now have two 'rpl.rpl_bug72457_myisam' and 'rpl.rpl_bug72457_innodb' which test the same (original) scenario with different values of '--internal-tmp-disk-storage-engine' and '--default-tmp-storage-engine' variables set to 'MyISAM' and 'InnoDB' correspondingly.
percona-ysorokin
force-pushed
the
ps-5.7-bugps1107-tmpdir_full
branch
from
dfc28fe to
a840f25
Compare
|
Updated Jenkins build link |
laurynas-biveinis
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PS-1107
Cherry-picked from ps-5.6-bugps1107-tmpdir_full branch
(commit c7b6226).
Fixed problem with wrapping 'reinit_io_cache()' inside
'MYSQL_BIN_LOG::do_write_cache()' with 'simulate_file_write_error' DBUG
directive. 'DBUG_SET("-d,simulate_file_write_error")' should be called
not only when 'reinit_io_cache()' fails but when it succeeds as welll.
Whithout this patch, any subsequent call to 'my_write()' ends up with
an infinite loop.
Reorganized 'rpl.rpl_bug72457' MTR test case. Instead, we now have two
'rpl.rpl_bug72457_myisam' and 'rpl.rpl_bug72457_innodb' which test the
same (original) scenario with different values of
'--internal-tmp-disk-storage-engine' and '--default-tmp-storage-engine'
variables set to 'MyISAM' and 'InnoDB' correspondingly.