PS-4790: Improve user statistics accuracy (5.7) #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently userstat measures times for mysql_parse, mysqld_stmt_reset, mysqld_stmt_fetch, mysqld_stmt_prepare, mysqld_stmt_execute. MariaDB measures times only for `mysql_parse` and `dispatch_command` which call above functions. Moreover MariaDB adds measurements for COM_INIT_DB, COM_REGISTER_SLAVE, COM_RESET_CONNECTION, and other in `dispatch_command`. It makes measurements of BUSY_TIME and CPU_TIME more accurate. This patch implements a similar solution that measures times only for `dispatch_command` and `mysql_parse` using newly created `sql/userstat.cc` and `sql/userstat.h`.
|
Testing started at https://ps.cd.percona.com/job/percona-server-5.7-param/127/ |
laurynas-biveinis
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently userstat measures times for mysql_parse, mysqld_stmt_reset, mysqld_stmt_fetch, mysqld_stmt_prepare, mysqld_stmt_execute.
MariaDB measures times only for
mysql_parseanddispatch_commandwhich call above functions.Moreover MariaDB adds measurements for COM_INIT_DB, COM_REGISTER_SLAVE, COM_RESET_CONNECTION, and other in
dispatch_command.It makes measurements of BUSY_TIME and CPU_TIME more accurate.
This patch implements a similar solution that measures times only for
dispatch_commandandmysql_parseusing newly createdsql/userstat.ccandsql/userstat.h.