Ps 5.7 4979 #2668
Merged
Ps 5.7 4979 #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 8, 2018 14:07
…d lead to a crash - There seems to be cases where the server doesn't detect an invalid table name and somehow ends up passing in an empty table name during the create call. The engine expects a table name in the form of a relative path like "./databasename/tablename". InnoDB detects this in parsing the table name during the creation and returns an error. TokuDB does not. - This commit adds an up-front parsing of the database and table names during creation and fails in the same way that InnoDB does if anything empty or unexpected is discovered. Also added a new simple test that illustrates the detection of the empty table name and error.
|
No jenkins yet because jenkins is still down, passes 100% of local tokudb mtr. |
laurynas-biveinis
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.