PS-5084: innodb_buffer_pool_size is an uninitialized variable (5.7) #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue in `innodb_buffer_pool_size_validate` when ```srv_buf_pool_size == static_cast<ulint>(intbuf)``` leads to ```*static_cast<longlong *>(save) = requested_buf_pool_size;``` is not called at all. Then there is an uninitialized read of var->save_result in innodb_buffer_pool_size_update.
laurynas-biveinis
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue in
innodb_buffer_pool_size_validatewhensrv_buf_pool_size == static_cast<ulint>(intbuf)leads to
*static_cast<longlong *>(save) = requested_buf_pool_size;is not called at all.
Then there is an uninitialized read of var->save_result in innodb_buffer_pool_size_update.