Fix TextField/CupertinoTextField hint style overflow not work. (#114335)

* fix text field hint style overflow not work, keep default ellipsis. * fix cupertino text field hint style overflow not work, keep default ellipsis. * add Cupertino placeholder style test.
percula · Nov 7, 2022 · 497a528 · 497a528
1 parent 496cf62
commit 497a528
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/packages/flutter/lib/src/cupertino/text_field.dart b/packages/flutter/lib/src/cupertino/text_field.dart
@@ -1133,7 +1133,7 @@ class _CupertinoTextFieldState extends State<CupertinoTextField> with Restoratio
                       child: Text(
                         widget.placeholder!,
                         maxLines: widget.maxLines,
-                        overflow: TextOverflow.ellipsis,
+                        overflow: placeholderStyle.overflow ?? TextOverflow.ellipsis,
                         style: placeholderStyle,
                         textAlign: widget.textAlign,
                       ),

diff --git a/packages/flutter/test/cupertino/text_field_test.dart b/packages/flutter/test/cupertino/text_field_test.dart
@@ -7485,4 +7485,29 @@ void main() {
       expect(controller.text, cutValue);
     }
   });
+
+  testWidgets('placeholder style overflow works', (WidgetTester tester) async {
+    final String placeholder = 'hint text' * 20;
+    const TextStyle placeholderStyle = TextStyle(
+      fontFamily: 'Ahem',
+      fontSize: 14.0,
+      overflow: TextOverflow.fade,
+    );
+
+    await tester.pumpWidget(
+      CupertinoApp(
+        home: Center(
+          child: CupertinoTextField(
+            placeholder: placeholder,
+            placeholderStyle: placeholderStyle,
+          ),
+        ),
+      ),
+    );
+    await tester.pumpAndSettle();
+    final Finder placeholderFinder = find.text(placeholder);
+    final Text placeholderWidget = tester.widget(placeholderFinder);
+    expect(placeholderWidget.overflow, placeholderStyle.overflow);
+    expect(placeholderWidget.style!.overflow, placeholderStyle.overflow);
+  });
 }