ci: Fix pin Java version to 8 in CI #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I looked into if it was possible to merge lists. Maybe soon?™ |
wwilsman
approved these changes
Aug 8, 2019
|
@wwilsman I am so hopeful for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
The version of Java installed on the node container we were using changed to Java 11 ~a month ago. That change broke our builds, so this PR uses a Java + node docker container (which defaults to node 10 & Java 8).
For the Node 8 step, I install NVM and install node 8 to test in. You can't merge two
stepskeys (as far as I know), so I just pulled the steps out into each version of node. A little duplication never hurts.