Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PercyAgent to be exported onto the window as PercyAgent #5

Merged
merged 4 commits into from
Sep 17, 2018

Conversation

djones
Copy link
Contributor

@djones djones commented Sep 12, 2018

screen shot 2018-09-12 at 10 30 45 am

@djones
Copy link
Contributor Author

djones commented Sep 12, 2018

This comment was helpful at figuring this out: TypeStrong/tsify#105 (comment)

@djones djones requested a review from fotinakis September 12, 2018 17:35
Copy link
Contributor

@fotinakis fotinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice! 🌮 with some thoughts/comments.

Would also love to have either a default export or a named export on the root @percy/agent module so then we could do:

import PercyAgent from '@percy/agent';

(without any /dist/public/percy-agent)
or, alternatively, a named export as import { PercyAgent } from '@percy/agent'; if we didn't want to make it the default.

@djones djones merged commit c24167b into master Sep 17, 2018
@djones djones deleted the david-jones/export-as-percy-agent branch September 17, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants