Fullpage SS Changes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankaj443
force-pushed
the
new-temp-endpoint
branch
from
169b6f4 to
9befb33
Compare
prklm10
force-pushed
the
new-temp-endpoint
branch
from
9befb33 to
1051820
Compare
ninadbstack
reviewed
Mar 1, 2023
Comment on lines
105
to
109
| if (options != null) { | ||
| provider.screenshot(name, options.getDeviceName(), options.getStatusBarHeight(), | ||
| options.getNavBarHeight(), options.getOrientation(), fullScreen); | ||
| provider.screenshot(name, options, fullScreen); | ||
| } else { | ||
| provider.screenshot(name, null, null, null, null, | ||
| fullScreen); | ||
| provider.screenshot(name, new ScreenshotOptions(), fullScreen); | ||
| } |
There was a problem hiding this comment.
maybe
options ||= new ScreenshotOptions();
provider.screenshot(name, options, fullScreen);
ninadbstack
reviewed
Mar 1, 2023
| return tiles; | ||
| } | ||
|
|
||
| public String screenshot(String name, ScreenshotOptions options, Boolean fullScreen) { |
There was a problem hiding this comment.
This is good refactor, I would want to make same for c# as well. Btw you can add fullScreen to options as well. Do not change customer side screenshot function though
ninadbstack
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes required for fullpage SS