Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a NullRef exception #61

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fixed a NullRef exception #61

merged 2 commits into from
Apr 3, 2023

Conversation

ninadbstack
Copy link
Collaborator

Changes:

  • Fixed a null ref exception for case when bstack exec failed for percyScreenshotBegin, we try to read from null result to get DeviceName

@ninadbstack ninadbstack force-pushed the PAPP-209-fix-null-execption-bstack-exec branch from 53aa109 to e4d89dc Compare March 31, 2023 08:54
pankaj443
pankaj443 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@pankaj443 pankaj443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ninadbstack ninadbstack merged commit d61a97d into master Apr 3, 2023
@ninadbstack ninadbstack deleted the PAPP-209-fix-null-execption-bstack-exec branch April 3, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankaj443 pankaj443 pankaj443 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninadbstack @pankaj443