Adding support for code based ignore elements #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankaj443
reviewed
Apr 10, 2023
| JSONObject tag = getTag(); | ||
| List<Tile> tiles = captureTiles(options); | ||
| return cliWrapper.postScreenshot(name, tag, tiles, debugUrl); | ||
| JSONObject ignoreRegion = findIgnoredRegions(options); | ||
| System.out.println("askdhskjdsjdf"); |
There was a problem hiding this comment.
please remove debug comments
pankaj443
reviewed
Apr 10, 2023
| for (String id : ids) { | ||
| try { | ||
| MobileElement element = (MobileElement) driver.findElementByAccessibilityId(id); | ||
| Point location = element.getLocation(); |
There was a problem hiding this comment.
we can reduce duplication for ignoreRegionsByXpaths & ignoreRegionsByIds
There was a problem hiding this comment.
lets keep it same in all sdks, it will only give slight refactor change which we will have to do in dotnet sdk as well to keep all sdks consistent as far as code is concerned
prklm10
force-pushed
the
PAPP-182_Add_support_to_ignore_elements
branch
from
2a13176 to
8e34621
Compare
ninadbstack
approved these changes
Apr 10, 2023
ninadbstack
reviewed
Apr 12, 2023
README.md
Outdated
| `Left` (int): Left coordinate of the ignore region. | ||
|
|
||
| `Right` (int): Right coordinate of the ignore region. | ||
| - Raises:ValueError: If top, bottom, left, or right is less than 0 or top is greater than or equal to bottom or left is greater than or equal to right. |
There was a problem hiding this comment.
correct exception class here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Support for code based ignore elements.