Adding Sync implementation #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanuk-browserstack
previously approved these changes
Jan 25, 2024
percy/lib/cli_wrapper.py
Outdated
| @@ -42,13 +42,13 @@ def is_percy_enabled(): | |||
| log(e, on_debug=True) | |||
| return False | |||
|
|
|||
| def post_screenshots(self, name, tag, tiles, external_debug_url=None, ignored_elements_data=None, considered_elements_data=None): | |||
| body = self._request_body(name, tag, tiles, external_debug_url, ignored_elements_data, considered_elements_data) | |||
| def post_screenshots(self, name, tag, tiles, external_debug_url=None, ignored_elements_data=None, considered_elements_data=None, sync=False): | |||
There was a problem hiding this comment.
Don't pass default value for sync
percy/lib/cli_wrapper.py
Outdated
| @@ -65,7 +65,7 @@ def post_failed_event(self, error): | |||
| "errorKind": 'sdk' | |||
| } | |||
|
|
|||
| response = requests.post(f'{PERCY_CLI_API}/percy/events', json=body, timeout=30) | |||
| response = requests.post(f'{PERCY_CLI_API}/percy/events', json=body, timeout=600) | |||
There was a problem hiding this comment.
why increase timeout here?
percy/lib/cli_wrapper.py
Outdated
| @@ -77,36 +77,38 @@ def post_failed_event(self, error): | |||
| log(e, on_debug=True) | |||
| return None | |||
|
|
|||
| def post_poa_screenshots(self, name, session_id, command_executor_url, capabilities, desired_capabilities, options=None): | |||
| def post_poa_screenshots(self, name, session_id, command_executor_url, capabilities, desired_capabilities, options=None, sync=False): | |||
There was a problem hiding this comment.
remove default value for sync
percy/lib/percy_automate.py
Outdated
| @@ -39,16 +40,18 @@ def screenshot(self, name: str, **kwargs): | |||
|
|
|||
| ignore_region_elements = [element.id for element in options.get(IGNORE_ELEMENT_KEY, [])] | |||
| consider_region_elements = [element.id for element in options.get(CONSIDER_ELEMENT_KEY, [])] | |||
| sync = options.get(SYNC, False) | |||
There was a problem hiding this comment.
Remove default value
percy/providers/app_automate.py
Outdated
| @@ -15,6 +15,7 @@ def supports(remote_url) -> bool: | |||
|
|
|||
| def screenshot(self, name: str, **kwargs): | |||
| session_details = self.execute_percy_screenshot_begin(name) | |||
| sync = kwargs.get('sync', False) | |||
Amit3200
approved these changes
Jan 29, 2024
Amit3200
reviewed
Jan 29, 2024
| driver.command_executor._url = 'https://hub-cloud.browserstack.com/wd/hub' | ||
| self.mock_webdriver.capabilities = { 'key': 'value' } | ||
|
|
||
| self.assertEqual(percy_screenshot(driver, 'Snapshot 3', options = {'sync': True}), 'sync-data') |
There was a problem hiding this comment.
use variable for assertion matching not hardcoded value
Amit3200
reviewed
Jan 29, 2024
| def mock_poa_screenshot(fail=False): | ||
| def mock_poa_screenshot(fail=False, sync=False): | ||
| body = '{ "success": ' + ("true" if not fail else 'false, "error": "test"') + "}" | ||
| if sync: body = '{ "success": "true", "data": "sync-data" }' |
There was a problem hiding this comment.
ideally this should be closer to actual data object.
Amit3200
approved these changes
Jan 30, 2024
shantanuk-browserstack
approved these changes
Jan 30, 2024
ninadbstack
reviewed
Jan 31, 2024
ninadbstack
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Sync implementation