Message option skipped if invalid URI #122
Comments
jaynetics
added a commit
to jaynetics/validates_url
that referenced
this issue
Oct 22, 2024
fixes perfectline#122. I could only run the specs by removing Gemfile.lock and would recommend perfectline#150 to be merged before this PR. Several examples were red with NoMethodErrors before I made any changes. I had to add the `value && ` to fix that. The example `does not allow a url with only a scheme` was also red. I had to add the `host.empty?` check to fix that one.
kritik
pushed a commit
that referenced
this issue
Oct 22, 2024
fixes #122. I could only run the specs by removing Gemfile.lock and would recommend #150 to be merged before this PR. Several examples were red with NoMethodErrors before I made any changes. I had to add the `value && ` to fix that. The example `does not allow a url with only a scheme` was also red. I had to add the `host.empty?` check to fix that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not actually using the gem but I was looking how it's implemented and noticed that when
rescue URI::InvalidURIErroris triggered you are applying:urlinstead ofoptions.fetch(:message)https://github.com/perfectline/validates_url/blob/master/lib/validate_url.rb#L66
The text was updated successfully, but these errors were encountered: