ansible-lint 6.x fixes; add ansible-lint github action #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhosoi
reviewed
Jan 13, 2023
| - { user: 'grafana' } | ||
| - { user: 'metrics', sasluser: 'metrics', saslpassword: 'p4ssw0rd' } | ||
| - {user: 'grafana'} | ||
| - {user: 'metrics', sasluser: 'metrics', saslpassword: 'p4ssw0rd'} |
There was a problem hiding this comment.
Out of curiosity, in which case are we supposed to keep single quotes vs. eliminate them?
There was a problem hiding this comment.
Do not use quotes unless you have to, especially for short module-keyword-like strings like present, absent, etc. But do use quotes for user-side strings such as descriptions, names, and messages.
In this case, {user: 'grafana'} - I would have to refer to the YAML standard to see if {user: grafana} is ok, since it is a JSON construct embedded within a YAML document.
natoscott
approved these changes
Jan 17, 2023
Get ansible-pcp working with ansible-lint 6.x and minimal exceptions
All tasks must be named - even `include_tasks` and `meta` tasks
Task names must start with uppercase letter
Use `true`/`false` instead of `yes`/`no`
Use `changed_when: false` for `command` and `shell` that run unconditionally
Add `set -o pipefail` for `shell` that use pipes. Note that `pipefail` is not
supported on Debian and some Ubuntu platforms, and the roles list them as
supported platforms.
Fix up jinja spacing
no spaces after `[`, `{` - no spaces before `]`, `}`
should have a single space before and after `|`
Other cleanup e.g. role meta/main.yml
In addition:
Do not use quotes for strings if not needed (Ansible "modern" style)
Remove unused handlers
Clean up tox.yml
Add separate github action for ansible-lint
Remove anything having to do with python code since this does not
provide any Ansible modules or other plugins
richm
force-pushed
the
ansible-lint-6.x-fixes
branch
from
32e6d42 to
b47459a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get ansible-pcp working with ansible-lint 6.x and minimal exceptions
All tasks must be named - even
include_tasksandmetatasksTask names must start with uppercase letter
Use
true/falseinstead ofyes/noUse
changed_when: falseforcommandandshellthat run unconditionallyAdd
set -o pipefailforshellthat use pipes. Note thatpipefailis notsupported on Debian and some Ubuntu platforms, and the roles list them as
supported platforms.
Fix up jinja spacing
no spaces after
[,{- no spaces before],}should have a single space before and after
|Other cleanup e.g. role meta/main.yml
In addition:
Do not use quotes for strings if not needed (Ansible "modern" style)
Remove unused handlers
Clean up tox.yml
Add separate github action for ansible-lint
Remove anything having to do with python code since this does not
provide any Ansible modules or other plugins