Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tic: Add I²C support for Tic Stepper Motor Controllers #78

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

z-riley
Copy link
Contributor

@z-riley z-riley commented Oct 25, 2024

This PR adds functionality for interfacing with Pololu Tic Stepper Motor Controllers over I²C.

The tic package is based on github.com/pololu/tic-arduino, with adoption of Go-style error handling, periph/conn, and other usability improvements.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 40.31008% with 231 lines in your changes missing coverage. Please review.

Project coverage is 47.6%. Comparing base (853aec6) to head (cbc94b0).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
tic/tic.go 33.1% 222 Missing and 6 partials ⚠️
tic/registers.go 93.5% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #78     +/-   ##
=======================================
+ Coverage   47.1%   47.6%   +0.5%     
=======================================
  Files         83      87      +4     
  Lines      10280   10935    +655     
=======================================
+ Hits        4837    5203    +366     
- Misses      5263    5538    +275     
- Partials     180     194     +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is excellent! The only blocking thing is that I believe Offset and its constants don't need to be exposed since they are not usable by the user.

tic/registers.go Outdated Show resolved Hide resolved
tic/registers.go Outdated Show resolved Hide resolved
tic/tic.go Show resolved Hide resolved
tic/tic.go Outdated Show resolved Hide resolved
@maruel maruel merged commit 5bc0352 into periph:main Oct 30, 2024
8 of 10 checks passed
@maruel
Copy link
Member

maruel commented Oct 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants