Improve CatalogManager to support multiple Cultures and make it thread-safe #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep cache of Catalog in multiple Culture - Add UICultureName token in FormatPattern - Return a constant EmptyCatalog for non existent translations.
|
looks good, thanks for contribution. Will update the package within next days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CatalogManager does not works well in a web environment because it is not thread safe and does not support multiple culture at the same time (Need to call Reset to switch from one culture to another).
This merge request try to improve this while remaining 100% compatible with existing behavior.