Remove extraneous use statement (#4193)
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Listing 14-7 of Chapter 14, the `use add_one;` statement is redundant and can be removed. Before the Rust 2018 edition, this statement was required to bring the `add_one` crate into scope, so it likely got missed during refactorings from that transition. By removing this line, the code becomes more concise and reflects the current best practices for using external crates in Rust. Issue #4186 --------- Co-authored-by: Chris Krycho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Listing 14-7 of Chapter 14, the
use add_one;statement is redundant and can be removed. Before the Rust 2018 edition, this statement was required to bring theadd_onecrate into scope, so it likely got missed during refactorings from that transition.By removing this line, the code becomes more concise and reflects the current best practices for using external crates in Rust.
Issue rust-lang#4186