Added initial debugger implementation. #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved parsing and optimization in a separate function in pest_meta.
|
Thanks, this certainly helps a lot! I'm just going to braindump some more ideas I have
I also hit #279, which might be related to the debugger. |
|
By the way, if you need these improvements soon, you could fork my own PR and work on a separate PR. I'm happy to close this one in favor of that. |
|
Yep, I was planning on doing that, but last week was quite busy for me. Hoping to work on something this week. |
|
@hansihe, any news regarding your progress? |
tomtau
pushed a commit
to tomtau/pest
that referenced
this pull request
Nov 20, 2022
based on the old PR by @dragostis: pest-parser#277 Changes that were made: - debugger core context was refactored and extracted to a lib (so that it could be used in other frontends, e.g. editor plugins) - CLI was extended using rustyline helpers to provide file completions, history etc. - applied suggestions from @hansihe from the old PR (pest-parser#277 (comment)): 1. added `ba` (add breakpoints at all rules) which is useful for stepping through the entire grammar, plus breakpoint deletions and loading input directly from readline; 2. added command line arguments. - changed the listener function to return a boolean, so that the debugger can signal back to a parsing thread to finish before reaching its input's EOF.
|
Made some improvements in this PR: #736 |
tomtau
pushed a commit
to tomtau/pest
that referenced
this pull request
Nov 20, 2022
based on the old PR by @dragostis: pest-parser#277 Changes that were made: - debugger core context was refactored and extracted to a lib (so that it could be used in other frontends, e.g. editor plugins) - CLI was extended using rustyline helpers to provide file completions, history etc. - applied suggestions from @hansihe from the old PR (pest-parser#277 (comment)): 1. added `ba` (add breakpoints at all rules) which is useful for stepping through the entire grammar, plus breakpoint deletions and loading input directly from readline; 2. added command line arguments. - changed the listener function to return a boolean, so that the debugger can signal back to a parsing thread to finish before reaching its input's EOF. historyfile init
tomtau
pushed a commit
to tomtau/pest
that referenced
this pull request
Nov 20, 2022
based on the old PR by @dragostis: pest-parser#277 Changes that were made: - debugger core context was refactored and extracted to a lib (so that it could be used in other frontends, e.g. editor plugins) - CLI was extended using rustyline helpers to provide file completions, history etc. - applied suggestions from @hansihe from the old PR (pest-parser#277 (comment)): 1. added `ba` (add breakpoints at all rules) which is useful for stepping through the entire grammar, plus breakpoint deletions and loading input directly from readline; 2. added command line arguments. - changed the listener function to return a boolean, so that the debugger can signal back to a parsing thread to finish before reaching its input's EOF. Co-authored-by: Dragoș Tiselice <[email protected]>
tomtau
added a commit
that referenced
this pull request
Nov 24, 2022
* feature: added a `pest_debugger` crate (fixes #98) based on the old PR by @dragostis: #277 Changes that were made: - debugger core context was refactored and extracted to a lib (so that it could be used in other frontends, e.g. editor plugins) - CLI was extended using rustyline helpers to provide file completions, history etc. - applied suggestions from @hansihe from the old PR (#277 (comment)): 1. added `ba` (add breakpoints at all rules) which is useful for stepping through the entire grammar, plus breakpoint deletions and loading input directly from readline; 2. added command line arguments. - changed the listener function to return a boolean, so that the debugger can signal back to a parsing thread to finish before reaching its input's EOF. Co-authored-by: Tomas Tauber <[email protected]> Co-authored-by: Dragoș Tiselice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98.
This implementation is quite rudimentary:
ParserStatewhen it reaches a breakpointI'm not completely convinced that we should merge this. But I think it makes for a decent proof-of-concept. Maybe someone would be interested in further work here? @hansihe, this should be good enough as-is for tracing 2.0 grammars.