implement Copy for Position and Span #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think at some point these contained bors: r+ |
|
Oh wait right CI is broken rn |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2021
534: implement Copy for Position and Span r=CAD97 a=kaikalii I would be very nice if these types were `Copy`. If they are not `Copy` for a reason (which I assume has to do with future-proofing), then go ahead and close this. Co-authored-by: Kai Schmidt <[email protected]>
|
Build failed: |
|
Sorry for the lint issues; we accidentally upgraded the version of clippy we were enforcing warning-freedom on (see #535), so new lints got through and broke CI unexpectedly. bors: r+ |
|
bors: r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would be very nice if these types were
Copy.If they are not
Copyfor a reason (which I assume has to do with future-proofing), then go ahead and close this.