Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validator for ignore Rule::line_doc for fix #781 "already defined" error. #782

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Update validator for ignore Rule::line_doc for fix #781 "already defined" error. #782

merged 2 commits into from
Jan 31, 2023

Conversation

huacnlee
Copy link
Member

No description provided.

@huacnlee huacnlee requested a review from a team as a code owner January 30, 2023 04:01
@huacnlee huacnlee requested review from NoahTheDuke and removed request for a team January 30, 2023 04:01
tomtau
tomtau approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a similar problem with grammar docs or only line docs?

@huacnlee
Copy link
Member Author

huacnlee commented Jan 30, 2023 •
edited
Loading

Only in line doc, because they defined in Rule::grammar_rule.

And I also changed test.pest for cover this.

@tomtau tomtau merged commit 5fae3b9 into pest-parser:master Jan 31, 2023
@huacnlee huacnlee deleted the fix-781 branch January 31, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

@NoahTheDuke NoahTheDuke Awaiting requested review from NoahTheDuke NoahTheDuke is a code owner automatically assigned from pest-parser/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huacnlee @tomtau