Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation of @octokit/request-error error.code #245

Merged

Conversation

thijsvtol
Copy link
Contributor

fixes:
image

@thijsvtol thijsvtol force-pushed the fix/deprecation-request-error branch from 9645285 to 61bffe6 Compare August 11, 2023 22:53
@thijsvtol
Copy link
Contributor Author

@peter-evans Please have a look

@peter-evans
Copy link
Owner

Hi @thijsvtol

Apologies for the slow response.

The deprecation message is unrelated to the error. "Resource not accessible by integration" is usually caused by the process not having access to the token it needs to perform the repository dispatch. This can happen if (for example) the workflow is triggered by a PR from a fork. For security reasons, some actions don't have access to tokens.

I'll look at the deprecation warning later when I have time, but I just wanted to let you know that it didn't cause the error.

@thijsvtol
Copy link
Contributor Author

Hi @peter-evans, I'm aware of the deprecation warning is not causing the error. However, it still needs to be fixed ;)

@peter-evans
Copy link
Owner

@thijsvtol It's likely it is deprecated as the message suggests, but strangely I don't see that warning. Can you show me your workflow or a run where this occurs?

See a run I executed today: https://github.com/peter-evans/repository-dispatch/actions/runs/6082839902/job/16501443779

@thijsvtol
Copy link
Contributor Author

I guess it will only appears when an error occurs :D

@peter-evans
Copy link
Owner

Of course, that makes sense. 🤦‍♂️

@peter-evans
Copy link
Owner

Looks good to me. Thank you for contributing!

@peter-evans peter-evans merged commit bf47d10 into peter-evans:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants