Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

Reimplement HttpRequest and HttpResponse #346

Open
peterhuene opened this issue Jul 16, 2019 · 0 comments
Open

Reimplement HttpRequest and HttpResponse #346

peterhuene opened this issue Jul 16, 2019 · 0 comments
Assignees
@peterhuene
Labels
awaiting release The issue has been resolved in the dev branch and is awaiting the next release to close. breaking change The resolution to the issue will be considered a breaking change. enhancement New feature or request
Milestone
0.12.0

Comments

@peterhuene
Copy link
Owner

peterhuene commented Jul 16, 2019 •
edited
Loading

HttpRequest and HttpResponse were the very first Azure Functions bindings implemented in Azure Functions for Rust.

They were implemented at a time when the RPC data was borrowed by the function, which explains their "read-only" interface.

As the data is now moved into the binding type, I think both types should expose the pure data underlying the RPC RpcHttp type as members.

This will also make implementing exposing sub-RPC types like the cookie data more ergonomic.

This will be a big breaking change.
@peterhuene peterhuene added this to the 0.11.0 milestone Jul 16, 2019
@peterhuene peterhuene self-assigned this Jul 16, 2019
@peterhuene peterhuene added breaking change The resolution to the issue will be considered a breaking change. enhancement New feature or request labels Jul 16, 2019
@peterhuene peterhuene mentioned this issue Jul 29, 2019
Open
@peterhuene peterhuene modified the milestones: 0.11.0, 0.12.0 Nov 10, 2019
@peterhuene peterhuene added the in progress Work is in progress label Nov 15, 2019
peterhuene added a commit that referenced this issue Nov 20, 2019
@peterhuene
Refactor HttpRequest and HttpResponse.
07b7192 
This commit refactors HttpRequest and HttpResponse to directly store the data
rather than an inner `RpcHttp`.

It also implements support for cookies in `HttpRequest`, `HttpResponse`, and
`ResponseBuilder`.

Also enables more lints and fixes the clippy warnings.

Binding attributes for parameters have moved to the parameters in the examples
and documentation.

Fixes #346.
Fixes #281.
@peterhuene peterhuene mentioned this issue Nov 20, 2019
Merged
@peterhuene peterhuene added awaiting release The issue has been resolved in the dev branch and is awaiting the next release to close. and removed in progress Work is in progress labels Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterhuene peterhuene

Labels
awaiting release The issue has been resolved in the dev branch and is awaiting the next release to close. breaking change The resolution to the issue will be considered a breaking change. enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
1 participant
@peterhuene