-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gems #917
Update gems #917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be working for me. Only thing I noticed is that running rails c outputs
/Users/thomascullen/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/pry-byebug-3.8.0/lib/pry-byebug/control_d_handler.rb:5: warning: control_d_handler's arity of 2 parameters was deprecated (eval_string, pry_instance). Now it gets passed just 1 parameter (pry_instance)
Although the console still loads.
@thomascullen I saw that as well but assumed it wasn't fixed in pry-byebug yet. But after investigating it seems that pry-byebug is currently not compatible with the latest pry so they added that in dependencies. But, there is an older version, that does not have that dependency version limitation so I pushed another commit, and here's the issue about incompatibility: deivid-rodriguez/pry-byebug#343 |
…phQL::Pagination::Connections`
Check in deivid-rodriguez/pry-byebug#343 before upgrading pry.
75726f1
to
00c7f94
Compare
@miharekar Ah nice, should be good to go then! |
Description
Split into several commits. The first 2 are simple but ideally we'd merge all:
nakayoshi_fork
to help with memoryuse GraphQL::Pagination::Connections
I've tested the oauth flows and puma forking. Could you do some extra testing as well? On the staging app perhaps?