Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when opening without a file #1

Closed
cassidyjames opened this issue Jan 30, 2018 · 5 comments
Closed

Crashes when opening without a file #1

cassidyjames opened this issue Jan 30, 2018 · 5 comments

Comments

@cassidyjames
Copy link

When I open the app from the desktop file, I think it'd make sense to throw open an "open file" dialog since the app doesn't really work without selecting an image first.

@cassidyjames
Copy link
Author

Alternatively, you could add a button in the UI to open an image (if an image isn't provided), it just depends on what you're thinking design-wise.

@cassidyjames cassidyjames changed the title Throw "open file" dialog when opening from .desktop file Crashes when opening without a file Jan 30, 2018
@peteruithoven
Copy link
Owner

I must admit that the app is mostly focused on working through the context menu (through the contract), I was mostly using the desktop file to test the icon.
But yeah, in the future and to prevent confusion I should find a way to make this app useful from the Applications menu.

Maybe I'll follow Wallpaperize's example.

peteruithoven added a commit that referenced this issue Jan 31, 2018
Since it's currently limited to context menu use only, see #1
@peteruithoven
Copy link
Owner

Example of how that might work:
frame 1

If opened with image(s) the "Drop Image(s) here" could be replaced with a image preview or a generic image icon.

The above concept also makes it clearer what the "Width" and "Height" are.

@cassidyjames
Copy link
Author

I like that! I think that's going to be required before publishing in AppCenter; right now we require apps to display in the applications menu so users can discover them. So you'll need to remove:

I'll also update the Before You Publish page on the wiki to reflect that since I realize it wasn't noted explicitly.

@peteruithoven
Copy link
Owner

This is fixed with version 0.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants