Retain and index downloads when locking. #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the local case of lock create and then later resolve, it will be good to retain the (primary) artifacts downloaded for the local interpreter when creating the lock used to lock in order to save downloading those artifacts again when later resolving from the lock. Work towards pex-tool#1583.
jsirois
commented
Mar 7, 2022
| return str(fp.read().decode("ascii")) | ||
|
|
||
|
|
||
| class DownloadManager(object): |
There was a problem hiding this comment.
N.B.: The forthcoming lock resolver will have its own implementation of this; thus factoring up the logic of where to store downloads for re-use / cache-hits centrally here.
jsirois
commented
Mar 7, 2022
| # type: (Artifact) -> DownloadedArtifact | ||
|
|
||
| download_dir = os.path.join(self._download_dir, artifact.fingerprint.hash) | ||
| with atomic_directory(download_dir, exclusive=True) as atomic_dir: |
There was a problem hiding this comment.
There is actually no need for this to be exclusive in this PR; however the lock resolver will also be implementing this and fetching URLs directly from PyPI most of the time. The exclusive lock will prevent two independent processes from trying to download the same artifact from PyPI concurrently and relieve a little pressure from PyPI as a result.
This was referenced Mar 7, 2022
Eric-Arellano
approved these changes
Mar 7, 2022
benjyw
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the local case of lock create and then later resolve, it will be
good to retain the (primary) artifacts downloaded by Pip for the local
interpreter when creating the lock in order to save downloading those
artifacts again when later resolving from the lock.
Work towards #1583.