Fix --venv cached Python interpreter info.
#2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the work dir path of the `atomic_directory` used to create the venv would leak into various cached paths in the `PythonInterpreter` `INTERP-INFO` file. Now, these paths are corrected at creation time. This is work towards `pex3 cache prune --last-access` which will need to iterate cached interpreters to find any associated with venvs such that the interpreter can be pruned when the venv is pruned.
jsirois
changed the title
--venv cacheded Python interpreter info.--venv cached Python interpreter info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the work dir path of the
atomic_directoryused to createthe venv would leak into various cached paths in the
PythonInterpreterINTERP-INFOfile. Now, these paths are corrected at creation time.This is work towards
pex3 cache prune --last-accesswhich will need toiterate cached interpreters to find any associated with venvs such that
the interpreter can be pruned when the venv is pruned.