Add README and supported python versions to PyPI description #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions to classifiers.
|
Per #259, updated operating system classifiers so users are aware Windows is not currently supported. |
| @@ -5,9 +5,11 @@ | |||
|
|
|||
| from setuptools import setup | |||
|
|
|||
| with open(os.path.join(os.path.dirname(__file__), 'README.rst')) as fp: | |||
| LONG_DESCRIPTION = fp.read() + '\n' | |||
There was a problem hiding this comment.
here's a preview of what this concatenation would look like: https://gist.github.com/kwlzn/97f740834edcc03b6e729a3b18d641dc
note the disjoint styling between the concatenation. seems to me that we'd probably want to change the style of the CHANGES.rst header, which is currently:
=======
CHANGES
=======
to something like:
Release Notes
===========
to make this blend nicely.
|
@kwlzn Good catch, updated PR to appropriately. |
|
LGTM! |
|
merged! thanks @johnthagen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #256.