Fix PEXBuilder.clone. #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously clone copied distributions twice. One copy was made by the underlying Chroot, and then another was manually performed. The manual copy was only needed to update the internal _distributions set, so just do that. A test that failed before the fix is added to ensure distributions with unwriteable files can be cloned. Fixes pex-tool#570
|
@fhoering if you have time to give this a review I'd be grateful. Thanks for finding this - it unearthed something surprising! |
Eric-Arellano
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously clone copied distributions twice. One copy was made by the
underlying
Chroot, and then another was manually performed. Themanual copy was only needed to update the internal
_distributionsset, so just do that.
A test that failed before the fix is added to ensure distributions with
unwriteable files can be cloned.
Fixes #570