fix undefined reference errors on mingw #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onnx_viewer, menoh_test and vgg16_benchmark refer to symbols under menoh_impl that are not exported from menoh DLL. This causes link error and failure of whole build process, which is nuisance for continuous integration. As a temporary measure to avoid the problem on mingw, this commit disable __declspec(dllexport) on mingw. If there are no __declspec(dllexport), gcc builds a DLL that exports all symbols.
|
I see. I will make a issue about that. I merge this PR anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onnx_viewer,menoh_testandvgg16_benchmarkrefer to symbols undermenoh_implthat are not exported from menoh DLL. This causes link error and failure of whole build process, which is nuisance for continuous integration.As a temporary measure to avoid the problem on
mingw, this commit disable__declspec(dllexport)on mingw. If there are no__declspec(dllexport), gcc builds a DLL that exports all symbols.cc: @durswd