-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UDP Broadcast Relay GUI package. Implement #10818 #1189
Conversation
Thanks so much for pulling this together, great package. Will continue testing. Some quick improvement suggestions:
|
Points 2 and 3 are solved by the second commit. I'll look into the rest. Great feedback! |
Thanks for the quick collaboration on this! Tried to install the latest commit and bumped into the post installation script error below.
|
Any suggestions on doing this? Currently the instance ID is tied to the config item ID.
Should be fixed now.
Now only interfaces with IPv4 or IPv6 addresses are shown. Where was this error shown?
I was thinking about this as well, but I found it better to leave this as examples on the online docs. Regarding the install issue on 2.7, you won't be able to install it there just yet. This is based on snapshots which are not yet public. I'll include an updated 2.6 pkg on the redmine with the latest fixes. |
Couple of ideas:
Thank you.
Error was shown when you manually start the service through the command line. The problem is that it's currently not visible in the interface if for whatever reason one of the instances fails to start. It would be great if we can somehow log the output of the rc.d script and show if something goes wrong (basically as soon as there is any output with the start command there is an issue).
Understand; we may want to make a link to the docs from the config page? It's more of a generic question for pfsense how intuitive we want to make it :-)
Makes sense, thanks. |
Thanks for the port!
|
That's odd since all of that worked when I checked. I'll check both versions. Thanks for testing. Edit: All good now - didn't unset referenced value after foreach loop; test pkg on redmine has been updated. |
Thanks for the update! With the latest update I can now see unique instances on a list however when I edit ID of any of them it doesn't change the existing one but creates a new entry instead - is this intentional? |
Hmm, selecting all and deleting has worked for me the entire time. If you edit the ID and that ID doesn't exist, it will indeed create a new entry. That part will be addressed once duplicate/conflicting entries are handled. Edit: Clicking the select all checkbox works for me on both Chromium and Firefox. |
I've added duplicates checking based on instance ID and port numbers.
There's
All pages include a dynamic help link. In this case, it's |
Can/May I help debug and thoroughly test this package? I'm currently/actually as of this moment in the process of configuring all kinds of multicast and broadcast for various devices in my network (utter pain), including the ones in the documentation as well as Weatherflow (udp broadcast port 50222), Unifi Cloud Key Protect (udp broadcast port 10001) and a couple of others. Previous experience Up until now I tried to use two instances based upon the following shell commands ( source -> https://forum.netgate.com/topic/155698/how-can-i-get-this-udp-relay-package-for-casting-across-vlans/75?loggedin=true ):
Only one instance seems to be valid at the moment and reboots of pfSense will not be survived. Software details |
If you add |
Just installed the latest package on a fresh install of DEVEL branch on FreeBSD 14. Configuration through the interface works without any issues. The /usr/local/etc/rc.d/udpbroadcastrelay.sh is not generated with config changes. This is the configuration.
|
Thanks! Copy/paste typo - should be good now. |
Thanks! The latest version on Redmine still has this issue - did you already publish a new package? https://redmine.pfsense.org/attachments/4449 |
Yes - the name is still the same so make sure to replace the old file. The change was on this line which now uses $instance:
I tried both 22.05 and 22.11 and the file was created correctly. |
Excellent, confirmed to work on 22.11 (did not try 22.05). |
Just saw version 1.0 over at Redmine and I get the following error when (uninstalled previous version 0.1.5 first): Update: made sure that there were no previous configs or any remnant left over files. Still same error is thrown as show below.
whereas
|
1.0 is only for dev branch. |
I'm actually getting the same error on 22.09-DEV. Thanks,
|
You must run dev 22.11, not 22.09. |
So glad you sirs are developing this. Thank you very much. However, my only issue right now is I cant add wireguard interface. Any solution to this? |
Thanks for doing this.
Thanks again |
I'll look into this. Edit: Wireguard interfaces do not support broadcast.
I don't recall any mention of IPv6 multicast support. Edit: There is no IPv6 support.
No. Try running the command manually to see if/where it fails. |
@djonk
This would log the ioctl error to the system log, but having an instance run successfully would result in an extra process: Edit: I ended up using a temporary file to capture the message. |
On 2.6, where does one find the udpbroadcastrelay application package? Installing this package manually results in a missing dependency. |
Following this thread, out of interest is it "good to go?" and just waiting merge / new release of PFsense? or is there still some items to test? |
Just put a comment on redmine. The 1.0 packaged worked well for me on 2.7.0/devel snapshots; initial and update configurations through UI. Thank you for creating this package. |
Keeping track of this in a separate internal MR to make things easier - closing this one. |
https://redmine.pfsense.org/issues/10818
General settings:
Edit: