Fix ntopng listen options #1398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l not work. While the current version of ntopng accepts a list for listen address, it only uses the last element in the list. This means that both an IPv4 and IPv6 listen address cannot be provided at the same time. Hopefully this will be fixed upstream at some point in the future. Until then, we limit the listen selection to one protocol. Additionally, bracket the address for IPv6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Redmine #15976 (https://redmine.pfsense.org/issues/15976)
If both IPv4 and IPv6 server listen are enabled, the IPv4 address will not work. While the current version of ntopng accepts a list for listen address, it only uses the last element in the list. This means that both an IPv4 and IPv6 listen address cannot be provided at the same time. Hopefully this will be fixed upstream at some point in the future. Until then, we limit the listen selection to one protocol.
Additionally, bracket the address for IPv6.