Redmine #7548 Add absolute offset to NTP stats #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all the unnecessary variables that were trying to calculate the index into the output array, when in fact it is just an incrementing index.
Actually it all works fine by just constructing each entry then appending to the output $obj array with $obj[] There is no need to have a $obj array index as a separate variable.
Plot and list the absolute value of the NTP time offset, as well as the existing plus/minus value. See Redmine https://redmine.pfsense.org/issues/7548 Forum https://forum.pfsense.org/index.php?topic=130468.0 for details. In order to do add this, it was easier to also refactor the whole code to get rid of the various counters and huge block of duplicated code for left and right. Those refactorings are in the commits before this one.
|
Can you please have a look @jdillard ? |
|
And let me know which part of the version/portrevision should be bumped for a change like this. |
jdillard
approved these changes
Jul 17, 2017
|
Thanks, @phil-davis! I had to merge this one manually, in e4c9e5f, because of the |
|
Yeh, I forgot all about this it has been there so long. Last week I cleaned up the large number of repo forks that I had from various projects - removing the ones that I do not use very often. Glad that GitHub does not delete the code waiting in PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plot and list the absolute value of the NTP time offset, as well as the existing plus/minus value.
See Redmine https://redmine.pfsense.org/issues/7548
Forum https://forum.pfsense.org/index.php?topic=130468.0
for details.
In order to do add this, it was easier to also refactor the whole code to get rid of the various counters and huge block of duplicated code for left and right. Those refactorings are in the various commits here, before the last one that implements the actual feature.