-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Google Authenticator #357
Conversation
net/pfSense-pkg-freeradius2/Makefile
Outdated
${INSTALL_DATA} ${FILESDIR}${PREFIX}/pkg/googleauth \ | ||
${STAGEDIR}/usr/local/etc/raddb/modules | ||
${INSTALL_SCRIPT} ${FILESDIR}${PREFIX}/pkg/googleauth.py \ | ||
${STAGEDIR}/usr/local/etc/raddb/scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace /usr/local
by ${PREFIX}
Also please add the new files on correspondent path inside files dir. Instead of add new file to files/usr/local/pkg
, add them to files/usr/local/etc/raddb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont get your second change request.
All files are already added into files/usr/local/etc/raddb
, arent they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you added 2 new files on FreeBSD-ports repository under net/pfSense-pkg-freeradius2/files/usr/local/pkg
and on Makefile you are installing them to STAGEDIR/usr/local/etc/raddb/scripts
. We try to keep the same directory structure under files/ that is used to install it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Now i get what you want :D
Will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Please rebase your fork and resolve conflicts |
${INSTALL_DATA} ${FILESDIR}${PREFIX}/etc/raddb/modules/googleauth \ | ||
${STAGEDIR}${PREFIX}/etc/raddb/modules | ||
${INSTALL_SCRIPT} ${FILESDIR}${PREFIX}/etc/raddb/scripts/googleauth.py \ | ||
${STAGEDIR}${PREFIX}/etc/raddb/scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. It's still missing ${MKDIR}
entries, like at line 31 in order to get ${STAGEDIR}/etc/raddb/modules
and ${STAGEDIR}/etc/raddb/scripts
directories created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, hope this was it :)
create directories
Changes done as requested. Is there still something missing? |
@whoot please bump PORTVERSION on Makefile just to make builders to catch up with the change and produce a new package |
bump PORTVERSION
@rbgarga Are we ready to go? |
This won't be quite so easy to merge at the moment so it'll be a bit delayed. FreeBSD is removing the FreeRADIUS 2.x port at the end of June so we have to get moved to FreeRADIUS 3.x ASAP. If I can, I'll try to integrate this along the way. If not we may need to have it redone after the 3.x package is available. We'll let you know. |
I manually merged this into the FreeRADIUS 3.x GUI package, closing. |
…llows BGP to function properly. See Netgate issue #357
Recent changes since MooseFS 3.0.112: * MooseFS 3.0.113-1 (2020-05-04) - (master) removed unnecessary debug syslog messages - (check) increased usleep tolerance due to some operating systems (issue #351) - (master) changed condition that decides if master should wait for more chunks during I/O - (mount) delayed setting channel for fuse notifications (very rare segfault in libfuse2 during init) - (client+master) changed conditions for ancestor test in getattr (issue #350) - (cs) added parameter for number of chunks to be send in single register packet - (cs) fixed reporting damaged chunks in testing function (issue #352) - (cs) removed some unnecessary damaged chunk notifications - (client) changed open test in setattr (related to issue #350) - (master) fixed handling truncate for open files (related to issue #350) - (master) added uid mapping in setfacl function - (master+client) added support for atomic truncate with open - (master+client) fixed keep cache conditions - (cs) introduced official label format defined in chunkserver configuration - (nbd) added readonly mode and locking - (cs) fixed condition in choosing disks for internal rebalance - (mount) added workaround in access for a bug in FreeBSD kernel (issue #354) - (cs) fixed master reconnection conditions (reload usually shouldn't cause reconnection) - (freebsd) fixed FreeBSD port (makeports.sh) - (master) changed disk removal detection algorithm (issue #356) - (cs) fixed calculating size limits - (cs) added handling inode limits in local filesystems on chunkservers (issue #358) - (master) added topology grouping when new chunks are about to be created (prefer closer servers) - (master) added more error messages to bgsaver - (cs) added changing subfolder during internal rebalance (related to issue #326) - (master+cs) added optional logging of long function execution times - (all) fixes of small errors found by static code analysers - (mount) turn off dentry invalidator for Linux kernels >= 4.19 (related to issue #357) - (master) changed condition that checks timestamp in changelogs (less prone to small clock differences) - (daemons) added time refresh function (for future use) - (cgi+cli) changed mark for removal state name UNKNOWN->PENDING (related to issue #359) - (client) decreased max IDLE time in writer module from 1s to 0.1s - (client) update inode in dentry invalidator - (tools) fixed mfscopyeattr, mfsseteattr and mfs*arch tools - (master+client) added support for new eattrs: immutable, appendonly, undeletable (setting new undeletable extra attribute appropriately can help with issues like #357) - (client) silenced "kern.proc.filedesc" syslog messages on FreeBSD (issue #360) PR: 246416 Submitted by: MooseFS FreeBSD Team <[email protected]> (maintainer)
Gives the possibility for a user to choose between mOTP and Google Authenticator in Freeradius, when using one-time-passwords.