Properly check domain when registering DHCP static mappings #533
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the PHP function "array_diff_assoc" results in any zone which is
a subdomain of a given static DHCP mapping domain being populated with
said mapping. In other words, a static DHCP mapping with a domain of
"domain.com" would appear in any zone that is a subdomain of it, such
as "sub1.domain.com" or "sub2.sub1.domain.com".
This fix changes the logic to perform a direct domain comparison so
that only the zone matching the exact domain specified in a given
static DHCP mapping will be populated with such a mapping entry.
Redmine issue: https://redmine.pfsense.org/issues/8619