-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show ECDSA CAs only with correct curves #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also needs to add a version bump to the package so it gets rebuilt, and a note somewhere that this change cannot be pulled back to RELENG_2_4_4 since it would break there. That's not necessarily a bad thing as on 2.5.0 it's using squid 4.x which will likely require other incompatible changes soon before release (#9158).
I think we need to add this func to cert.inc: function pkg_get_ca_or_certs($type, $none=False) {
$c_arr = array();
if ($none != False) {
$c_arr[] = array('refid' => 'none', 'descr' => 'none (auto)');
}
$ecdsagood = cert_build_list($type, 'IPsec');
foreach ($ecdsagood as $refid => $descr) {
$c_arr[] = array('refid' => $refid, 'descr' => $descr);
}
return $c_arr;
} |
I'll try to come up with a good generic option this week, then it can be used on all packages. |
In the same minute I pushed #712 I thought about it. Let me know when the generic function is available and I take care of using it on stunnel and freeradius |
I added an extra parameter to |
Redmine Issue: https://redmine.pfsense.org/issues/9901
Ready for review
Do not show incompatible ECDSA CAs for Squid HTTPS/SSL Interception
same as https://redmine.pfsense.org/issues/9897