Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show ECDSA CAs only with correct curves #709

Merged
merged 7 commits into from
Nov 27, 2019

Conversation

vktg
Copy link
Contributor

@vktg vktg commented Nov 15, 2019

Redmine Issue: https://redmine.pfsense.org/issues/9901
Ready for review

Do not show incompatible ECDSA CAs for Squid HTTPS/SSL Interception
same as https://redmine.pfsense.org/issues/9897

Copy link
Contributor

@jim-p jim-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also needs to add a version bump to the package so it gets rebuilt, and a note somewhere that this change cannot be pulled back to RELENG_2_4_4 since it would break there. That's not necessarily a bad thing as on 2.5.0 it's using squid 4.x which will likely require other incompatible changes soon before release (#9158).

@vktg
Copy link
Contributor Author

vktg commented Nov 23, 2019

same func as in #710 and #712

I think we need to add this func to cert.inc:

function pkg_get_ca_or_certs($type, $none=False) {
	$c_arr = array();
	if ($none != False) {
	        $c_arr[] = array('refid' => 'none', 'descr' => 'none (auto)');
	}
	$ecdsagood = cert_build_list($type, 'IPsec');
	foreach ($ecdsagood as $refid => $descr) {
		$c_arr[] = array('refid' => $refid, 'descr' => $descr);
	}
	return $c_arr;
}

@jim-p
Copy link
Contributor

jim-p commented Nov 24, 2019

I think we need to add this func to cert.inc

I'll try to come up with a good generic option this week, then it can be used on all packages.

@rbgarga
Copy link
Member

rbgarga commented Nov 25, 2019

I think we need to add this func to cert.inc

I'll try to come up with a good generic option this week, then it can be used on all packages.

In the same minute I pushed #712 I thought about it. Let me know when the generic function is available and I take care of using it on stunnel and freeradius

@jim-p
Copy link
Contributor

jim-p commented Nov 25, 2019

In the same minute I pushed #712 I thought about it. Let me know when the generic function is available and I take care of using it on stunnel and freeradius

I added an extra parameter to cert_build_list() which will generate this output format. https://redmine.pfsense.org/issues/9923 pfsense/pfsense@59fac81
Additionally, if you add a function_exists test that looks for cert_build_list(), packages could fall back to the old behavior, so that we can keep them in sync between 2.4.4 and 2.5.0.

@netgate-git-updates netgate-git-updates merged commit 65b14dd into pfsense:devel Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants