GSoC 2022: Manas Sivakumar Week 4

[Manas23601]

Changes proposed in this Pull Request:

• Updated All GitHub Workflows.
• Working on Knapsack driver implementation with necessary structs.
• Finalised on knapsack input signature.
• Experimented with add_directory method in CMake.
• Fixed Lint Errors on my code due to trailing white spaces and indentation mistakes.
• adjusted run.sh script to local setup

[cvvergara]

Change the title of your PR

[cvvergara]

do:

git fetch vrp

where vrp is the pgRouting/vrprouting/ repository
Then you will see that develop branch was updated,

git --cherry-pick a254552661157034001c139f83bb2a3c47e8ae35

To capture the change done.

[cvvergara]

Execute:

bash tools/scripts/code_checker.sh 

and that will check your code (so you dont get the lint error)
And fix what you need to fix

[cvvergara]

You might need to run it several times, because on the first error it stops

[cvvergara]

Lets keep the focus on the actions
instead of:

on:
  push:
    branches-ignore:
      - 'translations_*'
    tags: []
  pull_request:
    paths-ignore:
      - '**.po'

Use:

on:
  workflow_dispatch:

do that on all the ./github/worflow/*.yml
except on these 2 files:
ubuntu.yml, check-files.yml

[Manas23601]

The procedure to add google-or tools is not clear to me.
I explored two approaches :

1. Use the find_package function:

• This requires us to add the ortools root directory (which contains ortools.config) to the cmake_prefix_path. The problem with this approach is once you add ortools you have to add its dependencies as well to cmake_prefix_path(absl was the first one to come) and later the dependency's dependencies (sub dependency).
• After doing this for some time, I noticed some target files were missing in the location where it was looked for but was available in an another location. I Initially thought of looping over the folder and including all the src and config files but there doesn't seem to be any pattern in which the files are located within the directory.

2. Using add_directory:

• In this step you only need to add the ortools directory to the cmake. It apparently builds ortools with the existing cmake project and the dependencies are stored in the build folder.
• The problem here is in order to run a program with ortools files, the program needs to be inside the ortools folder and be run with make build SOURCE=\file\location and make run SOURCE=\file\location commands. I have no idea how to use ortools normally now after I have built it. Is there any option where I could just import the libraries ?
• VROOM seems to work in the above fashion. It is build separately and the src and lib files are included. but for ortools these files are all over the place

[Manas23601]

for adding ortools to cmake I downloaded the source code from github and built it using cmake. The workflow in ubuntu.yml is different,. I'm not downloading the binary version as a .tar.gz and extracting it