GSoC 2023: Aniket Agarwal Week 1 #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniket-debug
changed the title
Aniket-debug
changed the title
Aniket-debug
force-pushed
the
Aniket-week-1
branch
from
00ca7ad to
cd7791d
Compare
cvvergara
reviewed
Jun 5, 2023
| @@ -53,7 +53,7 @@ class Pgr_ksp : public Pgr_messages { | |||
| m_start(0), | |||
| m_end(0), | |||
| m_K(0), | |||
| m_heap_paths(false) { | |||
| m_heap_paths(false) { //! heap is for debuging purpose to check whether the algorithm is running well or not | |||
There was a problem hiding this comment.
Okay, so What is the significance of heap_paths from the user's perspective?
There was a problem hiding this comment.
Please see the topic about user on the gitter chat
There was a problem hiding this comment.
And the statement is false, because it is not for debugging purposes. The final user might want everything that was calculated, why who knows, only the final user knows why they need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Week one report
@pgRouting/admins