GSoC 2023: Aniket Agarwal Week 2 #295
Conversation
Aniket-debug
changed the title
| @@ -3,7 +3,8 @@ build | |||
| fix_typos | |||
| code_linter | |||
| src/version/version.h | |||
|
|
|||
| run.sh | |||
There was a problem hiding this comment.
While this is ok in this GSoC repository, this change would be unacceptable in the pgRouting repository.
You need to learn to live with the files that are "helper" files for the development you are doing, past present of future
For example, in my case I have zillions of files I have to see when I do a git status, and I live with them. Either I used them in the past, or I am using them, or I am preparing something for the future.
But none of them are to be included in the repository.
git status
On branch foo
Your branch is up to date with 'origin/foo'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
after.txt
astar_benchmark.pg
before.txt
change.sh
commitByDirectory.sh
commitBySubDirectory.sh
commits.sh
contributions.txt
contributors.txt
dmain.txt
errs.txt
exe.sh
get_contributors.sh
info.txt
install-all.sh
install-old-version.sh
install-one.sh
instructions.sh
nmain.txt
node_change.txt
orderedinfo.txt
page_history_gh_page.js
patch.cpp
pge_history_main.js
run.sh
taptest-4.sh
taptest.sh
update3.4.sh
v4.sh
| @@ -35,6 +35,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | |||
| #endif | |||
|
|
|||
| struct Path_rt { | |||
| /*Added route_id*/ | |||
There was a problem hiding this comment.
Modifying types will cause a lot of problems on the other functions.
I suggest you look how things are handled when there is an identifier of a route on the output.
There was a problem hiding this comment.
okay, that makes sense could you please tell me the name of the function that outputs path_id except pgr_ksp?
| @@ -4,6 +4,9 @@ File: ksp_driver.h | |||
| Copyright (c) 2015 Celia Virginia Vergara Castillo | |||
| Mail: [email protected] | |||
|
|
|||
| Copyright (c) 2023 Aniket Agarwal | |||
| Mail: [email protected] | |||
There was a problem hiding this comment.
Use at instead of @ one of our goals for v4 is to not have clickable mails to avoid unwanted mails from robots
| @@ -28,10 +31,57 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | |||
| --------------- | |||
|
|
|||
| --v2.6 | |||
| -- CREATE FUNCTION _pgr_ksp( | |||
There was a problem hiding this comment.
If you are marking a function for deletion, in SQL use /* */ to wrap the unwanted code
and a -- TODO if 0 <--- makes it easier to find the unwanted code that was forgotten to remove
There was a problem hiding this comment.
Forgot to mention, you can not delete an SQL function, this is a 3.6.0 which can only add functions from 3.5, you will have problems when testing updates.
TRSP had a similar problem and the way around was:
GSoC-pgRouting/sql/trsp/_trsp.sql
Line 59 in 81bcd0c
As you can see the old function remains, but the new one to be kept on v4 is named differently.
There was a problem hiding this comment.
okay, Got it Thank you.
There was a problem hiding this comment.
Forgot to mention, you can not delete an SQL function, this is a 3.6.0 which can only add functions from 3.5, you will have problems when testing updates. TRSP had a similar problem and the way around was:
GSoC-pgRouting/sql/trsp/_trsp.sql
Line 59 in 81bcd0c
As you can see the old function remains, but the new one to be kept on v4 is named differently.
Can I change SQL function?
| int64_t start_vid, | ||
| int64_t end_vid, | ||
|
|
||
| II_t_rt *combinations, |
There was a problem hiding this comment.
Remove name of parameters in header files
* added one-to-many overload and try to run pgtap on ksp * removed white spaces at the end of the lines * update function's developer * added overloads * fixing the errors * fixing more errors * added function's developer and updates in .hpp * fixed error of algorithm * fix the start_id and route_id problem * changes in ksp.sql to pass tests * fixing linting * fixing linter * added name in contributor list and added namspace comment
* added one-to-many overload and try to run pgtap on ksp * removed white spaces at the end of the lines * update function's developer * added overloads * fixing the errors * fixing more errors * added function's developer and updates in .hpp * fixed error of algorithm * fix the start_id and route_id problem * changes in ksp.sql to pass tests * fixing linting * fixing linter * added name in contributor list and added namspace comment
Added overloads:
@pgRouting/admins