Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #1236

Merged
merged 44 commits into from
Aug 1, 2019
Merged

Improvements #1236

merged 44 commits into from
Aug 1, 2019

Conversation

cvvergara
Copy link
Member

Makes some improvements

  • properly using MODULE_PATHNAME
  • some linting using codacy
  • removing from compiling some undocumented/not fully reviewed functions

@pgRouting/admins

cvvergara added 30 commits July 29, 2019 13:46
@cvvergara
[allpairs] properly using MODULE_PATHNAME
85a0d5b
@cvvergara
[alpha_shape] properly using MODULE_PATHNAME
990e36f
@cvvergara
[astar] properly using MODULE_PATHNAME
0331002
@cvvergara
[bdAstar] properly using MODULE_PATHNAME
76f48d8
@cvvergara
[bdDijkstra] properly using MODULE_PATHNAME
74349c4
@cvvergara
[chinese] properly using MODULE_PATHNAME
6e64313
@cvvergara
[components] properly using MODULE_PATHNAME
cc44d96
@cvvergara
[contraction] properly using MODULE_PATHNAME
5567190
@cvvergara
[dijkstra] properly using MODULE_PATHNAME
3583a14
@cvvergara
[drivingDistance] properly using MODULE_PATHNAME
714ac7c
@cvvergara
[ksp] properly using MODULE_PATHNAME
770119b
@cvvergara
[max_flow] properly using MODULE_PATHNAME
66b34e7
@cvvergara
[spanningTree] properly using MODULE_PATHNAME
c2d0a37
@cvvergara
[bellmanFord] properly using MODULE_PATHNAME
54b8185
@cvvergara
[dag] properly using MODULE_PATHNAME
43f181b
@cvvergara
[mincut] properly using MODULE_PATHNAME
b5a0728
@cvvergara
[lineGraph] properly using MODULE_PATHNAME
022c8e6
@cvvergara
[pickDeliver] properly using MODULE_PATHNAME
7cadf4c
@cvvergara
[tsp] properly using MODULE_PATHNAME
f8bd8a8
@cvvergara
[withPoints] properly using MODULE_PATHNAME
3c76cd2
@cvvergara
[pgtap] suppressing long TODO messages
6f2ba05
@cvvergara
[trsp] properly using MODULE_PATHNAME part 1
03f78f5
@cvvergara
[trsp] properly using MODULE_PATHNAME part 2
c70354c
@cvvergara
[travis] build the version queries before testing
29ab11d
@cvvergara
[vrp][sql] removing unused code
f0e3cc7
@cvvergara
[allpairs][sql] separating internal functions
dd9f493
@cvvergara
[dijkstra][sql] separating internal functions
aa461cb
@cvvergara
[drivingDistance][sql] separating internal functions
00bccdd
@cvvergara
[ksp][sql] separating internal functions
df5099d
@cvvergara
[lineGraph][sql] separating internal functions
aaf4f39
cvvergara added 13 commits July 30, 2019 09:32
@cvvergara
[max_flow][sql] separating internal functions
a479c65
@cvvergara
[mincut][sql] separating internal functions
06d3a67
@cvvergara
[pickDeliver][sql] separating internal functions
8d3ca4f
@cvvergara
[lint] Double quote to prevent globbing and word splitting
91acd55
@cvvergara
[lint] Use $(..) instead of legacy ..
0aa4d4b
@cvvergara
[lint] Declare and assign separately to avoid masking return values.
4e52558
@cvvergara
[lint] Grep uses regex, but this looks like a glob.
591b9e5
@cvvergara
[lint] Statements following return, break, continue, goto or throw wi…
785202a 
…ll never be executed.
@cvvergara
[lint] Function parameter should be passed by reference.
c143647
@cvvergara
[lint] reverting some changes that did not work
eee8b6b
@cvvergara
randomSpanningTree not included in 3.0
0f7e73d
@cvvergara
[bellmanFord] with negative edges not documented, so not including it…
a436967 
… in v3.0
@cvvergara
[bellmanFord] sending as TODO the tests
f8e0172
@cvvergara cvvergara added this to the Release 3.0.0 milestone Aug 1, 2019
@cvvergara cvvergara merged commit e379967 into pgRouting:develop Aug 1, 2019
@cvvergara cvvergara deleted the improvements branch August 1, 2019 15:37
nike0good
nike0good reviewed Aug 4, 2019
View reviewed changes
Copy link
Contributor

@nike0good nike0good left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read.

cvvergara added a commit to cvvergara/pgrouting that referenced this pull request Aug 26, 2021
@cvvergara
Merge pull request pgRouting#1236 from cvvergara/improvements
dded6af 
Improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nike0good nike0good nike0good left review comments

@dkastl dkastl dkastl approved these changes

@woodbri woodbri Awaiting requested review from woodbri

@rohithsankepally rohithsankepally Awaiting requested review from rohithsankepally

@robe2 robe2 Awaiting requested review from robe2

@cayetanobv cayetanobv Awaiting requested review from cayetanobv

@vidhan13j07 vidhan13j07 Awaiting requested review from vidhan13j07

@codeSG codeSG Awaiting requested review from codeSG

@vicennial vicennial Awaiting requested review from vicennial

@XJTUmg XJTUmg Awaiting requested review from XJTUmg

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cvvergara @dkastl @nike0good