Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx for focal 3.3.4 #2402

Merged

Conversation

cvvergara
Copy link
Member

Fixes #2400 .

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.3.4 milestone Oct 6, 2022
@cvvergara cvvergara requested a review from robe2 October 6, 2022 21:33
Copy link
Member

@robe2 robe2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure you want to do this? Could just disable doc building for systems that don't support higher sphinx no?

@robe2
Copy link
Member

robe2 commented Oct 6, 2022

I suppose maybe this change is fine for 3.3.4 since it's a regression in a stable version, but I wouldn't do it for 3.4.0, I'd just disable doc building if sphinx is lower for 3.4.0

@cvvergara
Copy link
Member Author

I am doing the same for 3.4
where I am not doing it is on develop

@krashish8 krashish8 merged commit 1497ac0 into pgRouting:release-3.3 Oct 7, 2022
@cvvergara cvvergara deleted the fix-sphinx-for-focal-3.3.4 branch November 28, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants